fix: broken alembic import with alembic 1.15. Solves issue #368 - #369
Open
thomas-dufour wants to merge 1 commit into
Open
fix: broken alembic import with alembic 1.15. Solves issue #368#369thomas-dufour wants to merge 1 commit into
thomas-dufour wants to merge 1 commit into
Conversation
|
@xzkostyan Could you take a look at this PR? It will be really helpful to merge this. |
|
@xzkostyan is there any chance this PR could be reviewed and released. The PR looks good, as the changes are the same that were done in the original alembic's PR. |
PabloReszczynski
approved these changes
Jun 19, 2025
Author
|
@PabloReszczynski thx for the approval. What about merging this PR (I don't know the process in this repo)? Is there anything I need to do? |
stankudrow
pushed a commit
to stankudrow/clickhouse-sqlalchemy
that referenced
this pull request
Nov 1, 2025
stankudrow
reviewed
Nov 1, 2025
Comment on lines
+40
to
+43
| elif alembic_version >= (1, 11, 0): | ||
| return sqla_compat._reflect_table(inspector, table) | ||
| else: | ||
| return _alembic_reflect_table(inspector, table, None) | ||
| return sqla_compat._reflect_table(inspector, table, None) |
There was a problem hiding this comment.
Suggested change
| elif alembic_version >= (1, 11, 0): | |
| return sqla_compat._reflect_table(inspector, table) | |
| else: | |
| return _alembic_reflect_table(inspector, table, None) | |
| return sqla_compat._reflect_table(inspector, table, None) | |
| if alembic_version >= (1, 11, 0): | |
| return sqla_compat._reflect_table(inspector, table) | |
| return sqla_compat._reflect_table(inspector, table, None) |
Just if is enough in lieu of an elif and then else clause because of immediate return statements.
Draft
5 tasks
pmirandaa
approved these changes
Nov 14, 2025
|
@thomas-dufour , @xzkostyan , hello. Is this PR finished and if so, when can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.