Introduce KafkaEngine support - #377
Open
jimenezj8 wants to merge 2 commits into
Open
Conversation
Author
|
@xzkostyan please let me know how to proceed with this PR, when you have the opportunity |
Author
|
@xzkostyan bumping this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds limited official support for KafkaEngine as requested in this ticket. Although documentation was added for extending
clickhouse-sqlalchemywith custom engines downstream, it would be beneficial to the community to add first-class support.For now, this PR adds logic to the
DDLCompilerin order to generateCREATE TABLEstatements using the new engine. This is an experimental engine, as stated by the ClickHouse docs. Tables with this engine should also never be read from directly - the query will simply fail, as noted by ClickHouse docs.Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.