fix(helm): Rename mcp-server port from "mcp" to "mcp-server" for consistency (fixes #2021).#2022
Open
junhaoliao wants to merge 3 commits intoy-scope:mainfrom
Open
fix(helm): Rename mcp-server port from "mcp" to "mcp-server" for consistency (fixes #2021).#2022junhaoliao wants to merge 3 commits intoy-scope:mainfrom
junhaoliao wants to merge 3 commits intoy-scope:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
WalkthroughHelm chart version bumped from 0.2.0-dev.1 to 0.2.0-dev.3 and port label renamed from "mcp" to "mcp-server" for mcp-server container and Service targetPort for naming consistency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
@junhaoliao Can we resolve the conflicts? |
junhaoliao
commented
Mar 3, 2026
| apiVersion: "v2" | ||
| name: "clp" | ||
| version: "0.2.0-dev.1" | ||
| version: "0.2.0-dev.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the Kubernetes port name for the
mcp-servercomponent from"mcp"to"mcp-server"so it follows the same naming convention as every other component in the Helm chart (where the port name matches the component name).Checklist
breaking change.
Validation performed
Ran
helm templateagainst the chart and confirmed:name: "mcp-server"for the container port.port: "mcp-server"in thereadinessProbe.httpGetandlivenessProbe.httpGetsections.targetPort: "mcp-server".Summary by CodeRabbit