refactor(integration-tests): Deprecate clp_mode_utils and adopt package-specific mode utilities; remove problematic running-mode validation for clp-presto and clp-json-s3 tests.#2243
Open
quinntaylormitchell wants to merge 2 commits intoy-scope:mainfrom
Conversation
Contributor
WalkthroughThis PR refactors the test infrastructure to simplify validation logic. Mode configurations are consolidated into dedicated utility modules, the validation function is renamed and streamlined to check only running Docker services (removing mode config correctness checks), and unused utility functions are removed. ChangesTest Infrastructure Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bill-hbrhbr
approved these changes
May 4, 2026
clp_mode_utils module.clp_mode_utils and adopt package-specific mode utilities; Remove problematic running-mode validation for clp-presto and clp-json-s3 tests.
clp_mode_utils and adopt package-specific mode utilities; Remove problematic running-mode validation for clp-presto and clp-json-s3 tests.clp_mode_utils and adopt package-specific mode utilities; remove problematic running-mode validation for clp-presto and clp-json-s3 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the
clp_mode_utilsmodule in favour of the mode descriptions fromtests/package_tests/clp_*/utils/mode.py.Checklist
breaking change.
Validation performed
Ran
uv run pytest -m 'package'anduv run pytest -m 'core'; all tests pass.Summary by CodeRabbit
Tests
Chores