Skip to content

refactor(webui): Migrate from npm workspaces to pnpm + Turborepo; fix pre-existing lint errors. #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junhaoliao wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(webui): Migrate from npm workspaces to pnpm + Turborepo; fix pre-existing lint errors. #2262

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1875010
refactor(webui): Migrate from npm workspaces to pnpm + Turborepo; fix…
junhaoliao May 8, 2026
e0426bc
chore(webui): Pin turbo to 2.9.10 in package.json
junhaoliao May 8, 2026
120c375
chore(taskfile): Remove redundant comments from webui task
junhaoliao May 8, 2026
918366e
refactor(taskfile): Add sources/generates to webui task for proper ca…
junhaoliao May 8, 2026
1d1b827
fix(webui): Add `^build` dependency to lint tasks in turbo config.
junhaoliao May 8, 2026
d0dd3f9
fix(lint): Fix yamllint line-length violation in lint.yaml; fix ruff …
junhaoliao May 8, 2026
82a51b3
refactor(webui): Move workspace packages into packages/ subdirectory
junhaoliao May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/webui/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Dependencies
node_modules/
yscope-log-viewer/

# Turborepo cache
.turbo/
4 changes: 2 additions & 2 deletions components/webui/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"build": "tsc -b && vite build",
"lint:check": "eslint . --max-warnings 0",
"lint:fix": "npm run lint:check -- --fix",
"lint:fix": "eslint . --max-warnings 0 --fix",
"dev": "vite"
},
"author": "YScope Inc. <dev@yscope.com>",
Expand All @@ -20,7 +20,7 @@
"@sinclair/typebox": "^0.34.41",
"@tanstack/react-query": "^5.90.19",
"@tanstack/react-query-devtools": "^5.91.2",
"@webui/common": "*",
"@webui/common": "workspace:*",
"antd": "^6.3.5",
"antlr4": "^4.13.2",
"axios": "^1.13.2",
Expand Down
7 changes: 2 additions & 5 deletions components/webui/client/src/pages/IngestPage/Jobs/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ import {
import dayjs from "dayjs";

import {SETTINGS_STORAGE_ENGINE} from "../../../config";
import {
CompressionJobStatus,
JobData,
} from "../Jobs/typings";
import {JobData} from "../Jobs/typings";
import {formatSizeInBytes} from "./units";


Expand Down Expand Up @@ -137,7 +134,7 @@ const mapCompressionJobResponseToTableData = ({
key: String(id),
paths: paths,
speed: speedText,
status: status as CompressionJobStatus,
status: status,
};
};

Expand Down
2 changes: 1 addition & 1 deletion components/webui/client/src/pages/SearchPage/SearchControls/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import GuidedControls from "./Presto/Guided/GuidedControls";
*
* @param ev
*/
const handleSubmit = (ev: React.FormEvent<HTMLFormElement>) => {
const handleSubmit = (ev: React.SyntheticEvent<HTMLFormElement>) => {
ev.preventDefault();
};

Expand Down
5 changes: 3 additions & 2 deletions components/webui/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
},
"scripts": {
"build": "tsc",
"build:watch": "npm run build -- -w --preserveWatchOutput",
"build:watch": "tsc -w --preserveWatchOutput",
"dev": "tsc -w --preserveWatchOutput",
"lint:check": "eslint . --max-warnings 0",
"lint:fix": "npm run lint:check -- --fix"
"lint:fix": "eslint . --max-warnings 0 --fix"
},
"author": "YScope Inc. <dev@yscope.com>",
"license": "Apache-2.0",
Expand Down
Loading
Loading