(clp-s::search): Scan ERT tables using column-based filtering#2281
(clp-s::search): Scan ERT tables using column-based filtering#2281ShangDanLuXian wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThis PR introduces ChangesColumnScan bitmap-based filtering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR adds an initial column-scan filter execution path for
clp_ssearch.The implementation is intentionally kept small and focused.
QueryRunnernow prepares the schema-table filter and attempts to useColumnScanfor supported predicates. If column scan cannot handle the query expression, the existing row-scan path is used as a fallback.Main changes:
ColumnScanundercomponents/core/src/clp_s/search/.AND/ORexpression trees.QueryRunner::prepare_filter.Checklist
breaking change.
Validation performed
id: 22419, observed total search time reduced from roughly 30s to roughly 15s on the test dataset, with table scan costs 1-2s.Summary by CodeRabbit
New Features
Chores