fix(kv-ir): Use Result-based error handling for encoded text AST deserialization for accurate error reporting.#2282
Open
LinZhihao-723 wants to merge 1 commit into
Open
Conversation
Contributor
WalkthroughIR stream decoding helper functions migrate from returning ChangesIR Stream Decoding Error Handling Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR,
deserialize_encoded_text_astwas using the legacy version of decoding methods to deserialize logtype and dict variables, which made the error code ambiguous when a truncated stream was encountered. This PR fixes the issue by unifying the implementation with the Result-based error handling to make sure the error codes are reported consistently as expected (noIRErrorCodeinvolved anymore).Checklist
breaking change.
Validation performed
Summary by CodeRabbit
Refactor
Documentation