test: Add new NFA test cases for schema rules with integers, a key-value pair capture group, and more complex repetition patterns.

[SharafMohamed]

Description

Add NFA tests for:

• Complex repetition case: capture:(a+=(?<val>1+),)+,
• Integer: int:\\-{0,1}\\d+,
• Key-value pair, value capture: keyValuePair:[A]+=(?<val>[=AB]*A[=AB]*).

Clean up existing tests to be more concise.

Validation performed

New tests run successfully.

Summary by CodeRabbit

• Tests
  • Added new test cases for more complex repetition, integer, and equality scenarios in NFA testing.
  • Improved formatting of expected NFA strings in existing tests for better readability.
  • Updated existing tests to streamline structure and remove redundant comments.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The test file tests/test-nfa.cpp was refactored to use multi-line string literals for expected NFA outputs, removed redundant comments, and expanded test coverage by adding four new test cases for various NFA scenarios. No changes were made to production code or public interfaces.

Changes

File(s)	Change Summary
tests/test-nfa.cpp	Refactored expected NFA string formatting to use multi-line literals, removed redundant comments, added four new test cases, and updated an existing test to include a test call. No logic or serialization changes.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant test_nfa
    participant NFA_Serializer

    TestRunner->>test_nfa: Provide schema and expected NFA string
    test_nfa->>NFA_Serializer: Serialize schema to NFA string
    NFA_Serializer-->>test_nfa: Return serialized NFA
    test_nfa-->>TestRunner: Compare to expected, report result

Loading

Possibly related PRs

• Constrain NFA states to contain only one negative transition. #46: Related due to both modifying NFA test cases and the NFA serialization format, though this PR only changes test code and coverage.

Suggested reviewers

• LinZhihao-723
• davidlion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SharafMohamed]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[davidlion]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[davidlion]

For the title, how about:

test: Add new NFA test cases for schema rules with integers, a key-value pair capture group, and more complex repetition patterns.