feat(spider-grpc): Add gRPC protocol for storage; Add gRPC liveness client in execution manager.#340
feat(spider-grpc): Add gRPC protocol for storage; Add gRPC liveness client in execution manager.#340sitaowang1998 wants to merge 6 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
WalkthroughThis PR expands the Spider storage API with gRPC services for job management, resource groups, and execution-manager liveness. It introduces type conversions between core and protobuf representations, implements a concrete GrpcLivenessClient wrapping the protobuf service, and re-exports the new types through the module hierarchy. ChangesExecution Manager Liveness and Job Management APIs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This PR:
spider-core.Checklist
breaking change.
Validation performed
Summary by CodeRabbit
Release Notes