fix(docs): Fix ClpS3AuthProviderBase anchor.#35
Merged
anlowee merged 1 commit intoy-scope:presto-0.293-clp-connectorfrom Sep 26, 2025
Merged
fix(docs): Fix ClpS3AuthProviderBase anchor.#35anlowee merged 1 commit intoy-scope:presto-0.293-clp-connectorfrom
ClpS3AuthProviderBase anchor.#35anlowee merged 1 commit intoy-scope:presto-0.293-clp-connectorfrom
Conversation
WalkthroughA documentation-only change adjusts a Sphinx reference anchor in velox/docs/develop/connectors.rst. The ClpS3AuthProviderBase anchor now includes a trailing colon. No other content, logic, or structure is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kirkrodrigues
approved these changes
Sep 26, 2025
Member
kirkrodrigues
left a comment
There was a problem hiding this comment.
For the PR title, how about:
fix(docs): Fix `ClpS3AuthProviderBase` anchor.
ClpS3AuthProviderBase in the connectors doc.ClpS3AuthProviderBase anchor.
6c826f7
into
y-scope:presto-0.293-clp-connector
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed the anchor syntax in the
velox/docs/develop/connectors.rst. This was induced from #21, however the CI didn't catch this as an error so the CI still passed.I just created an issue related to the CI problem here: #34
Checklist
breaking change.
Validation performed
End-to-end setup http server and checkout the page on browser.
Passed the CI.
Summary by CodeRabbit