chore: Upgrade Velox to 59b492 pointed by upstream Presto release-0.297-edge10.

[20001020ycx]

Description

This PR updates the Velox submodule to a newer upstream snapshot and adapts the CLP connector to remain compatible.

Commit 1 (1f22e5c) chore: Pull from upstream Velox open-source repo at commit facebookincubator@59b492a, this is the commit pointed by Presto release-0.297-edge10.

Commit 2 (7a75748) fix: CLP connector API adaptation and dependency upgrades to build against the new Velox version:

• API changes: Updated ClpConnector, ClpDataSource, ClpColumnHandle, and ClpTableHandle to conform to breaking Velox connector API changes:
  • ColumnHandle and ConnectorTableHandle now declare name() as pure virtual — implemented in ClpColumnHandle and ClpTableHandle.
  • createDataSource / ClpDataSource signatures updated to use Velox-defined type aliases ConnectorTableHandlePtr, ColumnHandleMap, and ConnectorInsertTableHandlePtr (all const-qualified in 0.297).
  • Global connector factory registry removed — replaced with direct ClpConnectorFactory instantiation.
  • DataSource::runtimeStats() / RuntimeCounter renamed to getRuntimeStats() / RuntimeMetric; supportsSplitPreload() is now const; connectorConfig() is no longer virtual.
• clp upgraded to commit f82e6114
• log-surgeon upgraded to commit 193e1f91
• spdlog upgraded to v1.15.3

Commit 3 (8c8ce56) — fix: update builder dockerfile for Velox 0.297 setup-ubuntu.sh changes

• Updates the builder image and fixes several missing CMake link dependencies and compile definitions. The many CMake changes are needed because upstream Velox uses VELOX_MONO_LIBRARY=ON by default, which compiles everything into one monolithic velox library — in that mode, missing target_link_libraries or target_compile_definitions entries are harmless since all symbols are in one binary. We use VELOX_MONO_LIBRARY=OFF (required by our CLP libraries), which builds each target as a separate library and exposes all missing dependencies as linker errors or silent #ifdef misses at runtime.

Commit 4 (7e3d007) — chore: apply clang-format and gersemi (CMake formatter) to CLP connector files

• The 0.297 upstream merge upgraded clang-format from v18 to v21 and added gersemi (CMake formatter) to the pre-commit config

---

Note for reviewers: Please only review 2nd and 3rd commit. The 2nd commit is relevant to the CLP Velox connector and warrants review, and the 3rd commit is fixing the breaking changes from ci workflow. The 1st commit is a merge commit from the upstream Velox open-source repository.

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

• All unit test passed
• End to end test
  • Query: SELECT CLP_GET_JSON_STRING() from clp.default.default limit 100
  • Set up: official clp package v0.9.0, OSS version of Presto with the integration of upstream Presto's 0.297, velox with changes in this PR (integration of upstream Presto's 0.297), and minio as the storage.
  • The result is returned as expected.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 2026-02-23-0.297-integration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gibber9809]

LGTM. For PR title how about:

chore: Upgrade velox to facebookincubator/velox@59b492 to match version used by Presto release-0.297-edge10.