Skip to content

fix: remove hardcoded dimensions in simple_example.py and update PictureProps to use TypedDict for better type safety #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

fix: remove hardcoded dimensions in simple_example.py and update PictureProps to use TypedDict for better type safety #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/simple_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ def main():
EXAMPLE_DIR / "images" / "python-logo.png",
left=(50, "pt"),
top=(100, "pt"),
width=(300, "pt"),
height=(80, "pt"),
)
.text(
"The Python logo",
Expand Down
11 changes: 8 additions & 3 deletions src/tppt/pptx/shape/picture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
from typing import IO, Literal, NotRequired, assert_never
from typing import IO, Literal, NotRequired, TypedDict, assert_never

from pptx.opc.constants import CONTENT_TYPE
from pptx.shapes.picture import Movie as PptxMovie
from pptx.shapes.picture import Picture as PptxPicture

from tppt.types import FilePath
from tppt.types import FilePath, Length, LiteralLength

from . import BaseShape, RangeProps


class PictureProps(RangeProps):
class PictureProps(TypedDict):
"""Picture properties."""

left: Length | LiteralLength
top: Length | LiteralLength
width: NotRequired[Length | LiteralLength]
height: NotRequired[Length | LiteralLength]


class PictureData(PictureProps):
"""Picture data."""
Expand Down