When disableEditing is true, enable editing via toolbars.#1403
Open
tleewu wants to merge 1 commit intoyabwe:masterfrom
Open
When disableEditing is true, enable editing via toolbars.#1403tleewu wants to merge 1 commit intoyabwe:masterfrom
tleewu wants to merge 1 commit intoyabwe:masterfrom
Conversation
Author
|
@nmielnik could you perhaps take a look at this PR and let me know if this is a feasible merge? |
|
This should be pushed live by now? |
|
Hey whats the update on this this is exactly what I need in my application |
MethDamon
approved these changes
Aug 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #1084
Description
Currently, when
disableEditing: trueand when you highlight a piece of text, you can see the Medium toolbar, but clicking on the buttons doesn't change the text sincecontenteditable=false.Fix: allow toolbar editing when disable editing
This is my first time contributing to this repo - would love to hear your thoughts and suggestions!