Skip to content

Comments

fix: css styles in prod#1661

Merged
yacosta738 merged 5 commits intomainfrom
fix/css-styles-in-prod
Feb 23, 2026
Merged

fix: css styles in prod#1661
yacosta738 merged 5 commits intomainfrom
fix/css-styles-in-prod

Conversation

@yacosta738
Copy link
Owner

@yacosta738 yacosta738 commented Feb 23, 2026

This pull request makes several adjustments to the Astro project configuration and shared styles to improve build stability and maintainability. The main changes involve disabling certain CSS optimizations that were causing issues, removing the astro-critters plugin, and updating shared CSS sources.

Build and CSS Optimization Adjustments:

  • Disabled CSS post-processing in the astro-compress plugin to prevent issues with broken scoped styles during production builds. Also, turned off inlining/minification of CSS in HTML minification settings for stability.
  • Removed the astro-critters plugin and its configuration, which was previously used for inlining critical CSS, to simplify the build and avoid potential conflicts. [1] [2]

Shared Styles Update:

  • Updated global.css in packages/shared to include @source directives for the portfolio and blog apps, ensuring shared styles are correctly sourced.

Summary by CodeRabbit

  • Chores
    • Updated CSS processing configuration to adjust optimization settings.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
yap-api e42ad0c Commit Preview URL

Branch Preview URL
Feb 23 2026, 07:02 PM

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad89f78 and e42ad0c.

📒 Files selected for processing (2)
  • apps/portfolio/astro.config.mjs
  • packages/shared/src/styles/global.css

📝 Walkthrough

Walkthrough

The PR disables CSS optimization in the Astro build configuration by removing the astro-critters integration and disabling CSS minification in the compress integration. Additionally, it expands the global stylesheet pipeline to include source paths from the portfolio and blog application directories.

Changes

Cohort / File(s) Summary
Build Configuration
apps/portfolio/astro.config.mjs
Removed astro-critters import and integration block. Modified astro-compress integration to disable CSS optimization (CSS: false) and HTML minifier CSS minification (minifyCSS: false).
Stylesheet Configuration
packages/shared/src/styles/global.css
Added two @source directives to expand CSS preprocessor source paths to include ../../../../apps/portfolio/src and ../../../../apps/blog/src.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 CSS minification takes a rest today,
Critters and colors fade away,
New sources sprouted, left and right,
The build hops forward, lighter and bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: css styles in prod' directly addresses the main change—disabling CSS optimizations in production builds to resolve style issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/css-styles-in-prod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🤖 CI Pipeline Results

Check Status
🔍 Lint & Type Check ✅ success
🧪 Unit Tests ✅ success
🏗️ Build ✅ success
🎭 E2E Tests ✅ success
📊 Code Quality ✅ success

Commit: c81ec15
Workflow: View Details

@yacosta738 yacosta738 merged commit 8eb19b4 into main Feb 23, 2026
40 checks passed
@yacosta738 yacosta738 deleted the fix/css-styles-in-prod branch February 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant