Fix issue #749: Handle special characters in search queries safely#761
Open
pr0vieh wants to merge 1 commit intoyacy:masterfrom
Open
Fix issue #749: Handle special characters in search queries safely#761pr0vieh wants to merge 1 commit intoyacy:masterfrom
pr0vieh wants to merge 1 commit intoyacy:masterfrom
Conversation
The parseQuery method had a bug that caused StringIndexOutOfBoundsException when searching for queries containing special characters like '&<--'. The issue occurred due to: 1. Improper index tracking in substring extraction 2. Unsafe string boundary checks 3. Unconditional index increment that could go out of bounds This fix: - Safely extracts tokens by checking boundaries (p > 0 and p > 1) - Differentiates between quoted and unquoted strings properly - Trims and validates extracted strings - Uses continue to skip empty tokens - Prevents StringIndexOutOfBoundsException thx smokingwheels Fixes yacy#749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parseQuery method had a bug that caused StringIndexOutOfBoundsException when searching for queries containing special characters like '&<--'.
The issue occurred due to:
This fix:
got it from #749 (comment) thx @smokingwheels
Fixes #749