Optimized ObjectEntityCache for Thread Safety and Memory Management#3392
Open
khresth wants to merge 4 commits intoyahoo:masterfrom
Open
Optimized ObjectEntityCache for Thread Safety and Memory Management#3392khresth wants to merge 4 commits intoyahoo:masterfrom
khresth wants to merge 4 commits intoyahoo:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the ObjectEntityCache class with thread safety mechanisms and memory management capabilities. The implementation adds concurrent access support through read-write locks and prevents unbounded cache growth through an LRU eviction policy.
Key Changes:
- Introduced
ReadWriteLocksynchronization for thread-safe cache operations - Implemented LRU eviction with a 10,000 entry limit to prevent memory leaks
- Added reverse mapping cleanup to maintain consistency during evictions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
elide-core/src/main/java/com/yahoo/elide/core/ObjectEntityCache.java
Outdated
Show resolved
Hide resolved
elide-core/src/main/java/com/yahoo/elide/core/ObjectEntityCache.java
Outdated
Show resolved
Hide resolved
…e.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves # (if appropriate): (New enhancement)
Description
Enhanced the
ObjectEntityCacheclass with thread safety and memory management optimizations. The implementation now supports concurrent access patterns and prevents memory leaks through LRU eviction.ReadWriteLocksynchronization for thread-safe cache operationsMotivation and Context
The original
ObjectEntityCacheimplementation was unbounded cache growth with no eviction mechanism and wasn't optimized for concurrent access patterns. This enhancement attempts to address these issues while maintaining the existing public API making Elide more robust in high concurrency scenarios.How Has This Been Tested?
ReadWriteLockusage with separate read/write pathsEnvironment:
Java 17 compilation target
Maven build system
Existing Elide test suite compatibility verified
Screenshots (if appropriate): N/A - Code optimization without UI changes
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.