Skip to content

Completing policy branches give leaders titles #13062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

govUA
Copy link
Contributor

@govUA govUA commented Mar 12, 2025

Accomplishments

  • Civilization leaders get titles for their corresponding branch with the most policies adopted

  • Titles for adopting branches are written in Policies.json along with other data for branches.

Roadmap

  • Titles for female leaders

  • Rework to be implemented as uniques

  • Title era succession

@yairm210
Copy link
Owner

  • Granting Titles should be done via a Unique - this means adding a new UniqueType like e.g. "Grants the title [comment]"
  • This will allow granting titles from anything - building certain wonders, tech research under conditions, etc
  • The question then remains - if we have multiple titles, which one wins? I would vote for 'the last one you got' so that your title changes throughput the ages as you progress

@yairm210
Copy link
Owner

Regarding male / female... Technically we could add a tag to civilizations like "male", "female" and then trigger by
"Grants the title [Lord] <for [Male] civilizations>"
"Grants the title [Lady <for [Female] civilizations>"
🤔

Now that I read this more thoroughly I see 2 things:

  • That it's not just granted at the end but by the majority... urgh, we'll need to think how to generify that
  • That this should be a template - like "Grants the title [Lord [name]]", "Grants the title [[name] the Pious]", since these phrases need to be translated and the word order could be different in other languages

@govUA
Copy link
Contributor Author

govUA commented Mar 13, 2025

Okay, will work on improvements

@Ouaz
Copy link
Contributor

Ouaz commented Mar 15, 2025

That this should be a template - like "Grants the title [Lord [name]]", "Grants the title [[name] the Pious]", since these phrases need to be translated and the word order could be different in other languages

For information, in latin languages (french, spanish, italian), the adjective form depends of the gender.

The Pious:

  • French: le Pieux (male), la Pieuse (female)
  • Spanish: el Piadoso (male), la Piadosa (female)

Etc.

With most of the titles (roughly 6 of 10, depending the language), there will be a discrepancy when the leader is a woman.

Well, there's only a bunch of female leaders, but it will be weird to read Marie-Thérèse le Pieux or Marie-Thérèse le Grand. :D

I don't know how the translation was handled in Civ5, though (I bet there's a discrepancy there).

@SomeTroglodyte
Copy link
Collaborator

in latin languages (french, spanish, italian), the adjective form depends of the gender
... less so in Latin itself (which is alive and kicking in Unciv).

And: Can still be handled with Yair's "<for [Gender-neutral] civilizations>" idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants