Customizable Golden Age label

[k-oa]

My biggest PR so far. Please destroy my code so i can grow as a programmer

[SomeTroglodyte]

destroy my code

Sorry, must question the concept first. Modders can already replace all this via mod-specific translation files, including English.properties.

[k-oa]

Modders can already replace all this via mod-specific translation files

Yes but not for one specific Civ.
http://www.megabearsfan.net/image.axd/2013/12/CivV-Carnival_musician_590x369_opt.jpg

[SomeTroglodyte]

but not for one specific Civ

Got it. Still, a lot of effort for a tiny little visual...

Sooo...

• var enteredGoldenAge = "You have entered a Golden Age" more data - really necessary? I think this could get away with just a "You enter a [Golden Age]" template and giving it the goldenAgeName in code. Maybe.
• getErrorSeverity - idea: Restrict length in (1..?)?
• DeprecationLevel.ERROR - well done to deprecate first (was looking for this from the moment I typed "sooo"), but convention is to give modders a few µs time to update!
• val nation = viewingCiv.nation in AlertPopup - why not val goldenAgeName = viewingCiv.nation.goldenAgeName if you're not even using it in the two candidate lines?
• uppercase() - makes me wonder. Could we leave this more open? Would non-latin languages profit? Different casing conventions or those not even using cases or those the std::libs so far ignore? Or more crass: uppercase before tr() so both lines Golden Age = and GOLDEN AGE = will need translation?
• template.properties untouched -> TFW would pick up Uniques and UniqueParameter instances automatically IIRC, so - are there obsolete entries?

That's as much as I can see without opening another Studio instance...

[k-oa]

• var enteredGoldenAge = "You have entered a Golden Age" more data - really necessary? I think this could get away with just a "You enter a [Golden Age]" template and giving it the goldenAgeName in code. Maybe.

I was thinking about conditions that you can't "enter" but that "arrive" or something like that.

But I agree. It isn't that necessary.

[k-oa]

• DeprecationLevel.ERROR - well done to deprecate first (was looking for this from the moment I typed "sooo"), but convention is to give modders a few µs time to update!

So ... DeprecationLevel.WARNING?

[SomeTroglodyte]

DeprecationLevel.WARNING

Meaning the players will see the mod "denigrated" on their new game screen right after getting the version with this PR. There was a warning for Options only so it would show only in modchecker... Maybe inspect git blame for how it was done in the past? Or Yair tells you.

[yairm210]

We're against adding extra fields when things can be one via a Unique, so the correct answer here is to add a unique e.g. "Golden Age is called [comment]"

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.