-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Customizable Golden Age label #13111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, must question the concept first. Modders can already replace all this via mod-specific translation files, including |
Yes but not for one specific Civ. |
Got it. Still, a lot of effort for a tiny little visual... Sooo...
That's as much as I can see without opening another Studio instance... |
I was thinking about conditions that you can't "enter" but that "arrive" or something like that. But I agree. It isn't that necessary. |
So ... DeprecationLevel.WARNING? |
Meaning the players will see the mod "denigrated" on their new game screen right after getting the version with this PR. There was a warning for Options only so it would show only in modchecker... Maybe inspect git blame for how it was done in the past? Or Yair tells you. |
"goldenAgeName": { "type": "string" }, | ||
"enteredGoldenAge": { "type": "string" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're against adding extra fields when things can be one via a Unique, so the correct answer here is to add a unique e.g. "Golden Age is called [comment]"
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
My biggest PR so far. Please destroy my code so i can grow as a programmer