-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable Golden Age label #13111
base: master
Are you sure you want to change the base?
Conversation
Sorry, must question the concept first. Modders can already replace all this via mod-specific translation files, including |
Yes but not for one specific Civ. |
Got it. Still, a lot of effort for a tiny little visual... Sooo...
That's as much as I can see without opening another Studio instance... |
I was thinking about conditions that you can't "enter" but that "arrive" or something like that. But I agree. It isn't that necessary. |
So ... DeprecationLevel.WARNING? |
Meaning the players will see the mod "denigrated" on their new game screen right after getting the version with this PR. There was a warning for Options only so it would show only in modchecker... Maybe inspect git blame for how it was done in the past? Or Yair tells you. |
"goldenAgeName": { "type": "string" }, | ||
"enteredGoldenAge": { "type": "string" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're against adding extra fields when things can be one via a Unique, so the correct answer here is to add a unique e.g. "Golden Age is called [comment]"
My biggest PR so far. Please destroy my code so i can grow as a programmer