New countable for adopted policies supports policyFilter #13191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeTroglodyte
changed the title
yairm210
reviewed
Apr 17, 2025
Comment on lines
+213
to
+216
| "Adopted [[Tradition] branch] Policies" to 7, | ||
| "Adopted [Liberty Complete] Policies" to 0, | ||
| "Adopted [[Liberty] branch] Policies" to 2, | ||
| "Adopted [[all] branch] Policies" to 5, |
There was a problem hiding this comment.
How can All be lower than just Tradition?!
There was a problem hiding this comment.
Not all, all branch = started branches. Commented somewhere. Yes maybe a confusing name but this way it didn't need new translation entries. Should change to "[started] branch"? "branch starter"? Dunno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I hope can serve as clean example on how to create new Countables.
The only complication was that it needed a cleaner policy creating tool in the TestGame class, having uninitialized lateinits like the older createPolicy leaves isn't sufficient to run Policy.matchesFilter on.