Another Countables Pass - RFC #13204
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the "engine" character of that interface
This was referenced Apr 15, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the 4 commits should be read individually, and each could be approved or rejected individually. I'm not drafting this because I had a slight prejudice you tend to overlook those.
Top to bottom:
"does not fit parameter type countable, but may be an incorrect use of \"${countable.text}\"."kind of output. Haven't yet invested many seconds into a design how to actually integrate that. Also to think about:Countables.TileResourcehaving no discernible pattern to them is what enforces a lot of the complications. To drop or not to drop (in favour of"[resourceFilter] Resources")? I fear we can't, but without that beast it would be so much easier...