Traded Declarations of War can affect single Civ instead of both trading Civs #14474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairm210
requested changes
Jan 6, 2026
itanasi
changed the title
itanasi
changed the title
yairm210
reviewed
Jan 6, 2026
yairm210
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/586194543280390151/586194543716859916/1457917180657270908
Currently, any traded Declaration of War defaults to pulling in the other Civ into a war (WarType.JoinWar).
However, we should be able to bribe another Civ to go to War even while we stay at Peace using DirectWar.
If both Civs in the Trade are not at war with the target Civ, then whoever trades the Declaration of War and only that Civ will instigate a war. Also detects if a War is already ongoing and will appropriately notify JoinWar.
Diplo2.txt