Add upon liberating a city trigger - #15357
Open
Fanfblrik wants to merge 4 commits into
Open
Conversation
Mirrors upon conquering a city for civ-wide triggered uniques (e.g. Romania Golden Age points). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Add cityfilter |
Owner
|
"Upon liberating cityFilter cities" to make it parse well with "any" |
Use upon liberating [cityFilter] cities so any reads naturally, and match the liberated city against the filter. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Done — trigger is now |
Contributor
Author
|
Motivation: RekMOD Romania UA — Golden Age points on liberating a city ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upon liberating [cityFilter] cities(UniqueTarget.TriggerCondition).CityConquestFunctions.liberateCityfor the liberating civ, filtered against the liberated city (e.g.[any]).anyaccepted as a cityFilter (alongsideall/All) so the phrasing reads naturally.Instantly gain [N] [Golden Age points] <upon liberating [any] cities>.Test plan