Skip to content

Add upon liberating a city trigger - #15357

Open
Fanfblrik wants to merge 4 commits into
yairm210:masterfrom
Fanfblrik:feature/upon-liberating-city-trigger
Open

Add upon liberating a city trigger#15357
Fanfblrik wants to merge 4 commits into
yairm210:masterfrom
Fanfblrik:feature/upon-liberating-city-trigger

Conversation

@Fanfblrik

@Fanfblrik Fanfblrik commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Engine support for RekMOD Romania (Golden Age points on liberate).
  • New trigger: upon liberating [cityFilter] cities (UniqueTarget.TriggerCondition).
  • Fired at the end of CityConquestFunctions.liberateCity for the liberating civ, filtered against the liberated city (e.g. [any]).
  • any accepted as a cityFilter (alongside all/All) so the phrasing reads naturally.
  • Compose as Instantly gain [N] [Golden Age points] <upon liberating [any] cities>.

Test plan

  • Civ with liberate GAP unique: liberate a city → GAP granted once.
  • Narrower filter only fires for matching liberated cities.
  • Conquer/puppet/annex without liberate → this trigger does not fire.
  • Existing conquer triggers unchanged.

Fanfblrik and others added 3 commits August 10, 2026 17:13
Mirrors upon conquering a city for civ-wide triggered uniques (e.g. Romania Golden Age points).

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@yairm210

Copy link
Copy Markdown
Owner

Add cityfilter

@yairm210

Copy link
Copy Markdown
Owner

"Upon liberating cityFilter cities" to make it parse well with "any"

Use upon liberating [cityFilter] cities so any reads naturally, and match the liberated city against the filter.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Fanfblrik

Copy link
Copy Markdown
Contributor Author

Done — trigger is now upon liberating [cityFilter] cities, matched against the liberated city (so [any] reads naturally). Also accepted any as a cityFilter synonym for all/All.

@Fanfblrik

Copy link
Copy Markdown
Contributor Author

Motivation: RekMOD Romania UA — Golden Age points on liberating a city (Gain … <upon liberating [any] cities>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants