fix: Change request method from get to input for includes
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this change is because of a deprecation: `Since symfony/http-foundation 7.4: Request::get() is deprecated, use properties ->attributes, query or request directly instead.` https://symfony.com/blog/new-in-symfony-7-4-request-class-improvements#deprecated-the-get-method
yajra
approved these changes
Dec 16, 2025
|
Please check the pipeline failure |
Contributor
Author
|
@peter-nassef I'm not sure what's the issue, I asked copilot but it seems the workflow yaml expects the branch to be |
yajra
changed the title
get to input for includesget to input for includes
yajra
approved these changes
Dec 30, 2025
yajra
pushed a commit
that referenced
this pull request
Dec 30, 2025
## [12.0.1](v12.0.0...v12.0.1) (2025-12-30) ### Bug Fixes * change request method from `get` to `input` for includes ([#35](#35)) ([63d7d8f](63d7d8f))
Owner
|
🎉 This PR is included in version 12.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is because of a deprecation:
Since symfony/http-foundation 7.4: Request::get() is deprecated, use properties ->attributes, query or request directly instead.https://symfony.com/blog/new-in-symfony-7-4-request-class-improvements#deprecated-the-get-method