Fix getDomainByName() to handle domain variations (#556) #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDomainByName() now correctly finds domains regardless of whether they were stored with protocol (http://, https://) or trailing slashes. The function first tries an exact match for backward compatibility, then falls back to normalized comparison by removing protocols and trailing slashes from both the search string and stored domain names. This fixes issue #556 where domains stored as "https://domain.de/" or "domain.de/" could not be found when searching for "domain.de".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDomainByName() now correctly finds domains regardless of whether they were stored with protocol (http://, https://) or trailing slashes.
The function first tries an exact match for backward compatibility, then falls back to normalized comparison by removing protocols and trailing slashes from both the search string and stored domain names.
This fixes issue #556 where domains stored as "https://domain.de/" or "domain.de/" could not be found when searching for "domain.de".