feat: reintroduce pretty-logging and update codebase for modern conventions#17
Merged
jamesainslie merged 8 commits intomainfrom Dec 5, 2025
Merged
feat: reintroduce pretty-logging and update codebase for modern conventions#17jamesainslie merged 8 commits intomainfrom
jamesainslie merged 8 commits intomainfrom
Conversation
…e console messages in `-v`/`--verbose`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Before: (running with
--verbose --debug)After: (running with
--verbose --debug)Description
This pull request includes the following updates and improvements:
Reinstated pretty-logging for compiled output and improved linting; details:
stave_output_file.goit produces - generated from (what is now, in the Stave codebase) themainfile.gotmpltemplate - make use of no dependencies that are not in the Go standard library.pkg/dependencies in particular - since that would create a "burrowing" dependency:n+1of Stave would depend on what was the latest release of Stave at that time, creating a non-repeatable development path.mainfile.gotmpl.TestOnlyStdLibtest with aTestNoSelfDependenciesthat enforces the new, more relaxed requirement (namely, thatmainfile.gotmplnot import anystavecode).Adjusted
LintGotarget dependencies to include the missingInitdependency.Reverted structured-logging for verbose option (
-v/--verbose) to simpler console messages.before:
after:
Removed deprecated
// +buildstatements for modern build tags.Replaced usages of deprecated
io/ioutilpackage with appropriate alternatives.Deleted
install_test.goas its functionality is now covered by CI's dogfooding bootstrap.