Rewrote to es6, fixed some minor issues #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage we can tool it as we need(by tooling webpack and babel)
forzagreen
reviewed
Jul 22, 2019
| export { | ||
| Ar, | ||
| Az, | ||
| En, |
There was a problem hiding this comment.
Let's keep language names in lower case for preparation for standardisation. The target is to use ISO 639-1 code for language names, in combination with country code. It would look like en_US, en_UK, fr, fr_FR.
cf. Locales and Languages Supported by Facebook and num2words
| "copy-webpack-plugin": "^5.0.3", | ||
| "eslint": "^6.0.1", | ||
| "eslint-config-airbnb-base": "^13.2.0", | ||
| "eslint-plugin-import": "^2.18.2", | ||
| "mocha": "^3.5.3", |
There was a problem hiding this comment.
Since we are dropping support node versions less than 8, can you please verify
- we are using latest versions for devDependencies
- remove unused dependencies from package.json (may be mocha ?)
|
Hi @boykovdmitriy , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I needed to use this library and I rewrote it for my needs. Hope you'll like it)