Skip to content

fix(website): Make pack button cancel work via keyboard #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamadashy merged 1 commit into from
May 21, 2026
Merged

fix(website): Make pack button cancel work via keyboard #1585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions website/client/components/Home/PackButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:class="{ 'pack-button--loading': loading }"
:disabled="!isValid && !loading"
:aria-label="loading ? 'Cancel processing' : 'Pack repository'"
type="submit"
:type="loading ? 'button' : 'submit'"
@click="handleClick"
Comment on lines +7 to 8

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly enables keyboard interaction for cancelling, the visual feedback (changing the background to red and showing the 'Cancel' text) is currently only triggered by the :hover state in the CSS. For a better keyboard experience, consider applying these styles to the :focus-visible state as well, so keyboard users get the same visual cue when the button is focused during processing.

>
<span class="pack-button__text pack-button__text--normal">
Expand All @@ -28,8 +28,9 @@ const props = defineProps<{
const emit = defineEmits<(e: 'cancel') => void>();

function handleClick(event: MouseEvent) {
// Only handle cancel on actual mouse clicks, not on form submission (Enter key)
if (props.loading && event.detail > 0) {
// type=button while loading prevents form submission, so any click
// (mouse or keyboard) safely signals cancel.
if (props.loading) {
event.preventDefault();
event.stopPropagation();
emit('cancel');
Expand Down
Loading