Skip to content

chore(renovate): Ignore @clack/prompts major update#1611

Merged
yamadashy merged 1 commit into
mainfrom
chore/renovate-ignore-clack-prompts
May 30, 2026
Merged

chore(renovate): Ignore @clack/prompts major update#1611
yamadashy merged 1 commit into
mainfrom
chore/renovate-ignore-clack-prompts

Conversation

@yamadashy

Copy link
Copy Markdown
Owner

Summary

Adds @clack/prompts to the renovate ignoreDeps list to defer its v1 major update.

Why

The root major dependencies update (#1607) is fully red. The cause is @clack/prompts v1:

  • v1 changed the text() validate callback argument from string to string | undefined.
  • src/cli/actions/initAction.ts:97 calls value.length directly, which now fails type-checking:
    src/cli/actions/initAction.ts(97,33): error TS18048: 'value' is possibly 'undefined'.
    
  • Because build (tsc) runs via the prepare lifecycle hook, every npm ci fails — so all CI jobs (lint, test, build, bundle, benchmark, …) cascade-fail at the install step.

Deferring the major bump keeps main green. The v1 migration (making the validate callback null-safe, plus reviewing other clack v1 behavioral changes) can be done in a dedicated follow-up.

Scope

Only @clack/prompts is ignored. typescript 6.0 and @secretlint/* 13 stay in the major group so CI can evaluate them on their own once clack is out of the batch.

Checklist

  • Run npm run test
  • Run npm run lint

intent(renovate): defer @clack/prompts v1 — the root major deps update (PR #1607) is fully red because v1 changed the text() validate callback arg to `string | undefined`, breaking the tsc build at src/cli/actions/initAction.ts:97 (TS18048); since build runs via the prepare hook, every npm ci fails and all CI jobs cascade-fail
decision(renovate): ignore only @clack/prompts, leaving typescript 6.0 and @secretlint/* 13 in the major group so CI can still evaluate them once clack is out of the batch

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

A single configuration line is added to ignore the @clack/prompts dependency in Renovate updates. A comment explains this prevents TypeScript compatibility issues in initAction.ts caused by v1's type changes to the text() validate argument.

Changes

Renovate Dependency Ignore

Layer / File(s) Summary
Add @clack/prompts to Renovate ignore list
.github/renovate.json5
The @clack/prompts dependency is added to ignoreDeps with a comment documenting that v1 changes the text() validate argument type to `string

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • yamadashy/repomix#1018: Modifies .github/renovate.json5's ignoreDeps list to exclude isbinaryfile from Renovate auto-updates.
  • yamadashy/repomix#1046: Updates .github/renovate.json5 by adding iconv-lite to the ignoreDeps list.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding @clack/prompts to Renovate's ignoreDeps list to defer its v1 major update.
Description check ✅ Passed The description provides comprehensive context including summary, rationale, scope, and completed checklist items, exceeding template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/renovate-ignore-clack-prompts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Renovate configuration in .github/renovate.json5 to ignore or pin @clack/prompts updates, preventing breaking changes in version 1 that would cause TypeScript compilation errors in initAction.ts. There are no review comments, and I have no feedback to provide.

@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

⚡ Performance Benchmark

Latest commit:5dce33f chore(renovate): Ignore @clack/prompts major update
Status:✅ Benchmark complete!
Ubuntu:0.67s (±0.01s) → 0.67s (±0.01s) · +0.00s (+0.6%)
macOS:0.55s (±0.19s) → 0.54s (±0.23s) · -0.01s (-2.2%)
Windows:1.01s (±0.03s) → 1.00s (±0.03s) · -0.01s (-1.0%)
Details
  • Packing the repomix repository with node bin/repomix.cjs
  • Warmup: 2 runs (discarded), interleaved execution
  • Measurement: 20 runs / 30 on macOS (median ± IQR)
  • Workflow run

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (c90beae) to head (5dce33f).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         121      121           
  Lines        4698     4698           
  Branches     1096     1096           
=======================================
  Hits         4269     4269           
  Misses        429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yamadashy yamadashy merged commit 416d042 into main May 30, 2026
48 of 50 checks passed
@yamadashy yamadashy deleted the chore/renovate-ignore-clack-prompts branch May 30, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant