chore(renovate): Ignore @clack/prompts major update#1611
Conversation
intent(renovate): defer @clack/prompts v1 — the root major deps update (PR #1607) is fully red because v1 changed the text() validate callback arg to `string | undefined`, breaking the tsc build at src/cli/actions/initAction.ts:97 (TS18048); since build runs via the prepare hook, every npm ci fails and all CI jobs cascade-fail decision(renovate): ignore only @clack/prompts, leaving typescript 6.0 and @secretlint/* 13 in the major group so CI can still evaluate them once clack is out of the batch Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughA single configuration line is added to ignore the ChangesRenovate Dependency Ignore
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration in .github/renovate.json5 to ignore or pin @clack/prompts updates, preventing breaking changes in version 1 that would cause TypeScript compilation errors in initAction.ts. There are no review comments, and I have no feedback to provide.
⚡ Performance Benchmark
Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 121 121
Lines 4698 4698
Branches 1096 1096
=======================================
Hits 4269 4269
Misses 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Adds
@clack/promptsto the renovateignoreDepslist to defer its v1 major update.Why
The root major dependencies update (#1607) is fully red. The cause is
@clack/promptsv1:text()validatecallback argument fromstringtostring | undefined.src/cli/actions/initAction.ts:97callsvalue.lengthdirectly, which now fails type-checking:build(tsc) runs via thepreparelifecycle hook, everynpm cifails — so all CI jobs (lint, test, build, bundle, benchmark, …) cascade-fail at the install step.Deferring the major bump keeps
maingreen. The v1 migration (making thevalidatecallback null-safe, plus reviewing other clack v1 behavioral changes) can be done in a dedicated follow-up.Scope
Only
@clack/promptsis ignored.typescript6.0 and@secretlint/*13 stay in the major group so CI can evaluate them on their own once clack is out of the batch.Checklist
npm run testnpm run lint