fix: Directory タブの登壇回数バッジから半角スペースを除去 - #814
Merged
Merged
Conversation
Template indentation around ×N was condensed by Vue into a leading half-width space. Render the count via data-count + CSS content so the badge shows ×N without whitespace. Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
Self-closing <span /> fails Vize typecheck on non-void HTML elements. Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
vuefes-japan-speakers | ea9813c | Commit Preview URL Branch Preview URL |
Aug 04 2026, 01:26 AM |
yamanoku
marked this pull request as ready for review
August 4, 2026 02:28
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
github-project-automation
Bot
moved this from Doing
to Done - 2026
in yamanoku Repositories KANBAN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
×9（先頭に半角スペース）と描画されていた問題を修正しました×Nをdata-count+ CSSafter:content-[attr(data-count)]で描画し、フォーマッタが改行を入れても空白が入らないようにしました<span />) は Vize typecheck で弾かれるため、明示的な></span>に変更しましたDirectory badges without space
Test plan
×9/×6（スペースなし）と表示されることvp run lint/vp run format:check/vp run typecheck/vp test runが通ることTo show artifacts inline, enable in settings.