fix: unify speaker name ushironoko → うしろのこ - #815
Merged
Conversation
2022/2023 used うしろのこ while 2026 used ushironoko, so DirectoryView treated them as separate speakers. Normalize the display name to うしろのこ. Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
Guard against reintroducing a separate ushironoko speaker entry that would split DirectoryView aggregation again. Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
yamanoku
marked this pull request as ready for review
August 4, 2026 09:57
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Set nameEn to ushironoko across 2022, 2023 panel entries and the 2026 solo talk so English mode shows the expected handle. Co-authored-by: Oyama Michinoku <0910yama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
うしろのこ、2026 ではushironokoと表記が分かれており、DirectoryView のスピーカー集約で別人扱いになっていましたsrc/data/speakers-2026.tsの表記をうしろのこに統一しました（公式スピーカーページ URL の slug はそのまま）nameEn: ["ushironoko"]を 2022 / 2023 / 2026 の各エントリに追加しましたTest plan
vp run lintvp run format:checkvp run typecheckvp test run/の DirectoryView で「うしろのこ」が 2022 / 2023 / 2026 のトークを持つ1件として表示されることを確認/speakers/うしろのこで各年の発表が一覧されることを確認ushironokoと表示されることを確認