fix(funasr): sanitize system Python environment - #62
Open
LauraGPT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:testregression test andnpm run test:unitentry pointContext
In the system-Python branch,
buildPythonEnvironment()starts by copyingprocess.env. It previously avoided assigning embedded values, but did not remove existingPYTHONHOME,PYTHONPATH,LD_LIBRARY_PATH, orDYLD_LIBRARY_PATHentries inherited from the launcher or an earlier runtime setup.Those stale paths can make the selected system Python fail before the model-download script starts, commonly with
ModuleNotFoundError: No module named 'encodings'.The original environment handling reported in #61 is already improved on
maincompared with thev1.0.1tag. This PR adds the remaining defensive cleanup plus a regression test so the failure does not return through inherited process state.Verification
npm run test:unit(1 passed)git diff --checkRelated to #61.