fix: keep FunASR server noise out of app logs - #65
Open
LauraGPT wants to merge 2 commits into
Open
Conversation
Author
|
Updated this PR at exact head Additional fix:
Validation on the current head: python -m pytest test_funasr_log_noise.py -q
python -m py_compile funasr_server.py test_funasr_log_noise.py
git diff --check origin/main...HEADResult: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Closes #64. The Python server uses stdout as the JSON IPC channel, while Electron currently records stderr as FunASR error output. FunASR/modelscope/tqdm progress lines and Python INFO logs can therefore pollute the app logs and appear as mojibake on Windows even though transcription succeeds.
Verification