Fix WithEndpoints and WithEnpointsResolver to rebuild the transport connector#39
Open
davidmz wants to merge 1 commit intoyandex-cloud:v2from
Open
Fix WithEndpoints and WithEnpointsResolver to rebuild the transport connector#39davidmz wants to merge 1 commit intoyandex-cloud:v2from
davidmz wants to merge 1 commit intoyandex-cloud:v2from
Conversation
Both methods created a new SDK instance but copied the old connector (sdk.conn) as-is. Since ConnectorImpl captures the EndpointsResolver at construction time, GetConnection continued using the old resolver, silently ignoring the override. Fix: create a new ConnectorImpl with the new resolver and the existing connection pool, so GetConnection uses the updated endpoint mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithEndpointsandWithEnpointsResolverreplacesdk.endpointResolverbut copy the oldsdk.connas-is. SinceConnectorImplcaptures theEndpointsResolverat construction time,GetConnectioncontinues to resolve endpoints through the original resolver, so the override is silently ignored.Fix rebuilds the
ConnectorImplwith the new resolver and the existing connection pool so thatGetConnectionuses the updated endpoint mapping.func (sdk *SDK) WithEndpoints(endpoints *endpoints.PrefixEndpointsResolver) *SDK { return &SDK{ ctx: sdk.ctx, - conn: sdk.conn, + conn: transport.NewConnector(endpoints, sdk.connPool), endpointResolver: endpoints, connPool: sdk.connPool, authenticator: sdk.authenticator, } }The same fix was applied to
WithEnpointsResolver.I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru.