Merged
Conversation
vhaldemar
reviewed
Jul 1, 2025
| class TextClassifiersModelResultBase(BaseResult, Sequence, Generic[TextClassificationResponseT]): | ||
| predictions: tuple[TextClassificationLabel, ...] | ||
| model_version: str | ||
| #: doc Number of input tokens provided to the model. |
Collaborator
There was a problem hiding this comment.
#: doc was just an example
"doc" word is unnecessary
| for prediction in result: | ||
| print(prediction) | ||
|
|
||
| print(f'input_tokens= {result.input_tokens}') |
Collaborator
There was a problem hiding this comment.
I prefer "f{result.input_tokens=}" usually, but it is okay
|
|
||
| async def main() -> None: | ||
| sdk = AsyncYCloudML(folder_id='b1ghsjum2v37c2un8h64') | ||
| sdk = AsyncYCloudML(folder_id='yc.fomo.storage.prod.service') |
Collaborator
There was a problem hiding this comment.
I don't really like this folder_id in the code.
I also don't like old version(
It is okay for now, but I will bump the related ticket
| assert len(result) == len(result.predictions) == 2 | ||
| assert result[0]['label'] == result[0].label == 'foo' | ||
| assert result[0].confidence < 0.5 | ||
| assert result[0].confidence > 0.5 |
Collaborator
There was a problem hiding this comment.
This is kinda strange - why confidence changed it polarity?
GBocharov
added a commit
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without examples yet