Merged
Conversation
vhaldemar
reviewed
Apr 2, 2025
| @pytest.fixture | ||
| def mock_dataset(mocker, tmp_path: Path) -> AsyncDataset: | ||
| """Create a mock dataset for testing.""" | ||
| sdk_mock = mocker.MagicMock() |
Collaborator
There was a problem hiding this comment.
Btw, what the benefits of the python-mock against the unittest.mock.MagicMock?
Collaborator
Author
There was a problem hiding this comment.
python-mock is integrated with pytest and removes mocks after test method
Collaborator
There was a problem hiding this comment.
Well, you use fixture for this, it is also removes everething.
Also, instead of mocker.patch there is builtin monkeypatch in pytest
vhaldemar
reviewed
Apr 2, 2025
vhaldemar
reviewed
Apr 2, 2025
GBocharov
pushed a commit
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.