Merged
Conversation
vhaldemar
force-pushed
the
prompt_truncation
branch
from
c2bf065 to
8843028
Compare
vhaldemar
force-pushed
the
prompt_truncation
branch
from
8843028 to
aa0d79d
Compare
vladnosiv
reviewed
Apr 8, 2025
|
|
||
| raise TypeError( | ||
| 'prompt truncation strategy could be "auto", ' | ||
| 'integer as for LastMessagesPromptTruncationStrategy shortcut ' |
There was a problem hiding this comment.
звучит как какая-то сильная завязка UX на то, что int в качестве шортката обязательно относится к LastMessages
по идее нет уверенности, что тут не появится какой-то другой стратегии тоже с одним int'ом на входе
более того при наличии рядом int'а для max prompt tokens становится прям неочевидно
GBocharov
pushed a commit
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.