Skip to content

Conversation

@Irisha
Copy link

@Irisha Irisha commented Jul 30, 2018

Optional Timeout for net.Client.

Optional Timeout for net.Client.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 75.008% when pulling cdffbe1 on Irisha:patch-1 into f60c514 on yandex:develop.

@direvius
Copy link
Contributor

direvius commented Aug 8, 2018

Is this a finished PR? The Timeout field is not used anywhere, or am I wrong?

@skipor
Copy link
Contributor

skipor commented Sep 2, 2018

Yes, the field is not used yet, we have discussed this in messenger.

@Irisha
Copy link
Author

Irisha commented Oct 16, 2018

Go’s http package doesn’t specify request timeouts by default, allowing services to hijack your goroutines. Always specify a custom http.Client when connecting to outside services.
https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

I have problem with absence timeout when I fire with keep-alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants