chore: declare the MSRV as Rust 1.88 - #103
Merged
Merged
Conversation
The crate never stated a minimum toolchain, so its real one drifted silently with whatever the code happened to use — until the previous commit it stood at 1.95, purely because of one `core::hint::cold_path()` call. It is now declared as 1.88 and pinned in three places: `rust-version` in the manifest, so cargo reports a clear "requires rustc 1.88" instead of a spray of unstable-feature errors; a CI job on exactly that toolchain, so the next newer-than-1.88 feature fails the pull request that introduces it; and the README, which states the policy — an MSRV bump is a minor version bump, never a patch one. 1.88 is what edition 2024 plus let-chains cost; nothing in the library needs more. The CI job checks `--lib` only: tests and benches pull in criterion and proptest, which track their own, newer minimum toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate never stated a minimum toolchain, so its real one drifted silently with whatever the code happened to use — until #102 it stood at 1.95, purely because of one
core::hint::cold_path()call.It is now declared as 1.88 and pinned in three places:
rust-version = "1.88"in the manifest, so cargo reports a clearerror: rustc 1.87.0 is not supported by the following packageinstead of a spray of unstable-feature errors;1.88 is what edition 2024 (1.85) plus let-chains (1.88) cost; nothing else in the library needs more. Verified in both directions:
cargo +1.88.0 check --lib --lockedpasses,cargo +1.87.0fails.The CI job checks
--libonly — tests and benches pull in criterion and proptest, which track their own, newer minimum toolchain.