feat: support skipping api version #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Not against it, just a bit concerned the only way to understand how this function really works is by reading the test 🤔 |
Owner
|
Could you maybe update the readme to explain how to use this? 🙏 |
levenleven
force-pushed
the
skip-version
branch
from
5f02d62 to
325af32
Compare
levenleven
force-pushed
the
skip-version
branch
from
325af32 to
e6479f3
Compare
Contributor
Author
|
@yannh thanks for looking into this. I've added a usage example. |
Owner
|
Let me think about this a bit more, I'm wondering if it might be confusing to have -skip for many different types of parameters... thinking if it might be better to have -skipkind -skip-versions etc, or something else... UI wise I'm a bit concerned this could get confusing 🤔 |
|
This feature is very interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support skipping api version (in addition to already supported skip by kind and apiVersion/kind)
Closes #169