Skip to content

fix: update duration validation to use strfmt package #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nissy-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update duration validation to use strfmt package #348

nissy-dev wants to merge 1 commit into from

Conversation

@nissy-dev
Copy link

@nissy-dev nissy-dev commented Dec 10, 2025 •
edited
Loading

Fix #347

I ran the tests locally and confirmed they passed without any issues.

make local-test
go test -race ./... -count=1
?   	github.com/yannh/kubeconform/cmd/kubeconform	[no test files]
?   	github.com/yannh/kubeconform/examples	[no test files]
?   	github.com/yannh/kubeconform/pkg/cache	[no test files]
ok  	github.com/yannh/kubeconform/pkg/config	1.370s
ok  	github.com/yannh/kubeconform/pkg/loader	9.785s
ok  	github.com/yannh/kubeconform/pkg/output	2.142s
ok  	github.com/yannh/kubeconform/pkg/registry	3.501s
ok  	github.com/yannh/kubeconform/pkg/resource	2.594s
ok  	github.com/yannh/kubeconform/pkg/validator	3.079s

nissy-dev
nissy-dev commented Dec 10, 2025
View reviewed changes
pkg/validator/validator.go
func validateDuration(v any) error {
// Try validation with the Go duration format
if _, err := time.ParseDuration(v.(string)); err == nil {
if _, err := strfmt.ParseDuration(v.(string)); err == nil {
Copy link
Author

@nissy-dev nissy-dev Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more appropriate to use https://github.com/kubernetes/kube-openapi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'2w' is not valid duration

1 participant

@nissy-dev