Set partition line on framing edge, not midline#805
Open
GioMusto wants to merge 2 commits intoyaqwsx:masterfrom
Open
Set partition line on framing edge, not midline#805GioMusto wants to merge 2 commits intoyaqwsx:masterfrom
GioMusto wants to merge 2 commits intoyaqwsx:masterfrom
Conversation
GioMusto
force-pushed
the
partition-line-fix
branch
from
356b3fe to
45cfe75
Compare
GioMusto
force-pushed
the
partition-line-fix
branch
from
96afb54 to
f0519f9
Compare
GioMusto
force-pushed
the
partition-line-fix
branch
from
f0519f9 to
f89a03f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #803 by making sure partition lines are on the edge of the frame. As you can see from the comparison below, now tabs are correctly created for boards that don't span the entire length of the panel.
If just the first commit is applied, some frame cuts are not generated, making the separation of the boards difficult. The second commit solves that, but generate "useless" cuts that I'm not sure it's possible to remove.
Another issue is that the frame cuts are not generated in all the other cases, making it a little bit diffucult to separate the boards in the railstb case. I also think that tightframe should generate cuts.
Finally, one thing I don't understand is the strange overlap between the frame and the backbone when using railstb. I don't know if it can be a problem (see picture).
I'm pretty new to KiKit so I don't know if the PR can break something. In any case I hope it can still be helpful in order to address #803.