Skip to content

(chore): add support for DEEPL_API_URL environment variable in DeeplClient #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hnccox-yard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(chore): add support for DEEPL_API_URL environment variable in DeeplClient #2

hnccox-yard wants to merge 1 commit into from

Conversation

@hnccox-yard
Copy link

@hnccox-yard hnccox-yard commented Jun 17, 2025

No description provided.

@hnccox-yard hnccox-yard requested a review from mvdhoek1 June 17, 2025 07:50
@mvdhoek1
Copy link

mvdhoek1 commented Jun 17, 2025

  1. Deze plug-in staat ook in de WordPress repo dus het gebruik van env variabelen gaat niet voor iedereen werken. Daarom liever via een settings page
  2. Waarom wil je precies de base url kunnen overschrijven? (https://github.com/yardinternet/plugin-yard-deepl/blob/main/src/Clients/DeeplClient.php#L10)
  3. getenv() is ook niet helemaal veilig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonvanWijhe SimonvanWijhe SimonvanWijhe approved these changes

@mvdhoek1 mvdhoek1 Awaiting requested review from mvdhoek1

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hnccox-yard @mvdhoek1 @SimonvanWijhe @hnccox