feat!: cliui is now ESM only #165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deno related code updated to support wrapping and test now passing. A high level question is with the Deno support for node packages so good, is there any benefit to continuing to publish a deno build separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Wrapping issues: #89 #138
Wrapping PRs: #139 #143
See also yargs issue for ESM only: yargs/yargs#2451
Proposing require Node.js 20 since 18 is dropping out of LTS on 2025-04-30. Hopefully 20 will have require(esm) by default in v20.19.0: nodejs/node#57349
To do: