Fix SurveyMonkey Android SDK manifest

[kahakai]

Hello! According to the Google Play's target API level requirement,

Starting in November 2022, app updates must target API level 31 or above and adjust for behavioral changes in Android 12.

Looking at the section Migrate from Android 11 (API level 30) to Android 12 (API level 31), there is a point about Intent filters.

Intent filters: If your app contains activities, services, or broadcast receivers that use intent filters, you must explicitly declare the android:exported attribute for these components.

I did explicitly declare the android:exported attribute for all the components of the app beforehand as it has been a best-practice for Android development and even recommended by Google in the documentation for long time.

If you set the targetSdkVersion to 31 then builds fail because of react-native-survey-monkey. You will see a generic message Manifest merger failed with multiple errors, see logs.

Running Gradle with the --info flag helps as it logs the task and manifest merger steps.

Here you go, the last one before a fail is com.surveymonkey:surveymonkey-android-sdk:2.0.0, specifically com.surveymonkey.surveymonkeyandroidsdk.SMFeedbackActivity.

The problem with the abandoned SurveyMonkey Mobile SDK is that the android:exported attribute is not declared in the manifest and probably never will, thus we have to add it by ourselves. We don't have the source code of the SDK because it is distributed as an AAR (Android library), look at the surveymonkey-android-sdk repository.

Luckily, we have an ability to manage Manifest files with build tools. All the manifest files are combined into one file. We can tweak the SurveyMonkey Android SDK manifest with the merge node marker to add the required android:exported attribute.

TLDR: I added the now required android:exported attribute to the SurveyMonkey Android SDK manifest.

[mikemonaco]

Thanks for this fix, helped us out! I also was having problems with

implementation 'com.surveymonkey:surveymonkey-android-sdk:2.0.0'

I was getting the following error

Could not find com.surveymonkey:surveymonkey-android-sdk:2.0.0

I ended up making my own fork which bundles the aar file directly as well as implementing your fix: mikemonaco@8999ec7

[rangerscience]

It looks like maybe @yarikpwnzer is no longer active on Github, but @rMozes is. What's needed to get this merged? :)