[Feat] Adding header metric in thrift handler for unsafe headers - #2431
Open
pulkit4tech wants to merge 10 commits into
Open
[Feat] Adding header metric in thrift handler for unsafe headers#2431pulkit4tech wants to merge 10 commits into
pulkit4tech wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
+ Coverage 85.13% 85.18% +0.05%
==========================================
Files 279 280 +1
Lines 16611 16657 +46
==========================================
+ Hits 14141 14189 +48
+ Misses 2010 2009 -1
+ Partials 460 459 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pulkit4tech
commented
Feb 16, 2026
|
|
||
| func (t thriftNoWireHandler) checkAndEmitUnsafeHeaders(meter *observability.MeterInfo, treq *transport.Request) { | ||
| if meter == nil || meter.Edge == nil || treq == nil { | ||
| fmt.Printf("Unable to emit unsafe headers metric due to missing meter info or request: meter=%v, treq=%v\n", meter, treq) |
Collaborator
Author
There was a problem hiding this comment.
I'll remove this, was testing.
pulkit4tech
force-pushed
the
adding-header-metric-in-thrift-handler
branch
from
February 16, 2026 13:41
7b82621 to
9540c69
Compare
pulkit4tech
force-pushed
the
adding-header-metric-in-thrift-handler
branch
from
February 16, 2026 15:07
9540c69 to
5147ad7
Compare
bananacocodrilo
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow -

setting MetricInfo in Obs middleware and used in thrift handlers
RELEASE NOTES: Adding header metric in thrift handler for unsafe headers