transport/grpc: remove redundant header canonicalization - #2481
Open
bananacocodrilo wants to merge 1 commit into
Open
transport/grpc: remove redundant header canonicalization#2481bananacocodrilo wants to merge 1 commit into
bananacocodrilo wants to merge 1 commit into
Conversation
transportRequestToMetadata 712 ns -> 671 ns (-6%) metadataToTransportRequest 748 ns -> 614 ns (-18%) getApplicationHeaders 488 ns -> 397 ns (-19%)
bananacocodrilo
force-pushed
the
grpc-header-canonicalization-optimization
branch
from
July 14, 2026 16:08
390793b to
1bd25e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES:
Removed redundant header canonicalization in gRPC transport
transportRequestToMetadata 712 ns -> 671 ns (-6%)
metadataToTransportRequest 748 ns -> 614 ns (-18%)
getApplicationHeaders 488 ns -> 397 ns (-19%)
Inbound request MD (handler.go:107-111) — metadata.FromIncomingContext(ctx). grpc-go docs: "All keys in the returned MD are lowercase."
Response trailer MD (outbound.go:135-137) — populated by grpc-go from the wire. Same as request MD
Outbound application headers (transportRequestToMetadata, response_writer.go:66-70) — come from transport.Headers.Items(). transport.Headers has unexported fields and its only mutator With() lowercases keys via CanonicalizeHeaderKey;