Move OpenTracing span tags to StartSpan options for correct OTel bridge mapping - #2516
Open
vprithvi wants to merge 1 commit into
Open
Move OpenTracing span tags to StartSpan options for correct OTel bridge mapping#2516vprithvi wants to merge 1 commit into
vprithvi wants to merge 1 commit into
Conversation
…ge mapping Move span.kind, peer.service, and http.url tags from post-creation Set() calls into the Tags map passed to StartSpan. This ensures the tracer sees all tags at span creation time, which is required for correct SpanKind mapping through the OTel-OpenTracing bridge and for tag-aware sampling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move span.kind, peer.service, and http.url tags from post-creation Set() calls into the Tags map passed to StartSpan. This ensures the tracer sees all tags at span creation time, which is required for correct SpanKind mapping through the OTel-OpenTracing bridge and for tag-aware sampling.
RELEASE NOTES:
Move some OpenTracing tags into StartSpan