Merged
Conversation
All the included fonts were causing the repo size and the dist size to increase substantially. Not all glyphs included in the .ttf files will actually be used in real-life. As such, this commit refactors the fonts to subset fonts with limited glyphs. NotoSans-Regular has been left as-is to support all unicode characters as a fallback font. Note that there is also an issue with FPDF2, that causes fallback fonts to not work sometimes if they have a space in the name. As such, I have changed all font names to remove spaces. See py-pdf/fpdf2#1535 for more details.
yashovardhan99
added
the
T-enhancement
yashovardhan99
added
T-refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the included fonts were causing the repo size and the dist size to increase substantially. Not all glyphs included in the .ttf files will actually be used in real-life. As such, this commit refactors the fonts to subset fonts with limited glyphs. NotoSans-Regular has been left as-is to support all unicode characters as a fallback font.
Note that there is also an issue with FPDF2, that causes fallback fonts to not work sometimes if they have a space in the name. As such, I have changed all font names to remove spaces. See py-pdf/fpdf2#1535 for more details.