Feature implementation from commits 1e5f242..6f877a0 #1
Conversation
…1.26.0 (square#4330) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Support primitive types for `@Tag`
Test up to JDK 24
* Update dependency com.google.protobuf:protobuf-gradle-plugin to v0.9.5 * Correct ignored sources for errorprone --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.3 (square#4337) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….10.2 (square#4338) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
) * Update dependency com.google.guava:guava to v33.4.7-android * Ugh, Guava, whyyyy --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jake Wharton <[email protected]>
…10.0 (square#4341) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…quare#4344) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
![codeowlai[bot]](https://avatars.githubusercontent.com/in/1259765?s=60&v=4){kind=small}
| private final boolean streaming; | ||
|
|
||
| GsonRequestBodyConverter(Gson gson, TypeAdapter<T> adapter) { | ||
| GsonRequestBodyConverter(Gson gson, TypeAdapter<T> adapter, boolean streaming) { |
There was a problem hiding this comment.
🐛 Correctness Issue
Breaking API Change: Constructor Parameter Added.
Adding a required parameter to the constructor will break all existing code that instantiates this class directly.
📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
| GsonRequestBodyConverter(Gson gson, TypeAdapter<T> adapter, boolean streaming) { | |
| GsonRequestBodyConverter(Gson gson, TypeAdapter<T> adapter, boolean streaming) { |
| @@ -0,0 +1,48 @@ | |||
| /* | |||
| * Copyright (C) 2025 Square, Inc. | |||
There was a problem hiding this comment.
🐛 Correctness Issue
Invalid copyright year (2025).
The copyright year is set to 2025, which is in the future and could cause licensing issues.
Current Code (Diff):
- * Copyright (C) 2025 Square, Inc.
+ * Copyright (C) 2023 Square, Inc.📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
| * Copyright (C) 2025 Square, Inc. | |
| * Copyright (C) 2023 Square, Inc. |
This PR contains changes from a range of commits from the original repository.
Commit Range:
1e5f242..6f877a0Files Changed: 13 (7 programming files)
Programming Ratio: 53.8%
Commits included:
... and 6 more commits