Skip to content

Commit 0508c79

Browse files
committed
Fixes
1 parent 4928f6e commit 0508c79

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

src/core/handshaker/security/secure_endpoint.cc

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -708,17 +708,23 @@ class SecureEndpoint final : public EventEngine::Endpoint {
708708
: wrapped_telemetry_info_(std::move(wrapped_telemetry_info)) {}
709709

710710
std::vector<size_t> AllWriteMetrics() const override {
711-
return wrapped_telemetry_info_->AllWriteMetrics();
711+
return wrapped_telemetry_info_
712+
? wrapped_telemetry_info_->AllWriteMetrics()
713+
: std::vector<size_t>{};
712714
}
713715

714716
std::optional<absl::string_view> GetMetricName(
715717
size_t key) const override {
716-
return wrapped_telemetry_info_->GetMetricName(key);
718+
return wrapped_telemetry_info_
719+
? wrapped_telemetry_info_->GetMetricName(key)
720+
: std::nullopt;
717721
}
718722

719723
std::optional<size_t> GetMetricKey(
720724
absl::string_view name) const override {
721-
return wrapped_telemetry_info_->GetMetricKey(name);
725+
return wrapped_telemetry_info_
726+
? wrapped_telemetry_info_->GetMetricKey(name)
727+
: std::nullopt;
722728
}
723729

724730
private:

test/core/event_engine/test_suite/tests/endpoint_test.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,16 +128,20 @@ TEST_F(EventEngineEndpointTest, WriteEventCallbackEndpointValidityTest) {
128128
SliceBuffer client_write_slice_buf;
129129
SliceBuffer server_write_slice_buf;
130130
WriteArgs client_write_args;
131+
auto client_telemetry_info = client_endpoint->GetTelemetryInfo();
131132
std::vector<size_t> client_write_metrics =
132-
client_endpoint->GetTelemetryInfo()->AllWriteMetrics();
133+
client_telemetry_info ? client_telemetry_info->AllWriteMetrics()
134+
: std::vector<size_t>{};
133135
client_write_args.set_metrics_sink(WriteEventSink(
134136
client_write_metrics,
135137
{WriteEvent::kSendMsg, WriteEvent::kScheduled, WriteEvent::kSent,
136138
WriteEvent::kAcked, WriteEvent::kClosed},
137139
event_cb));
138140
WriteArgs server_write_args;
141+
auto server_telemetry_info = client_endpoint->GetTelemetryInfo();
139142
std::vector<size_t> server_write_metrics =
140-
server_endpoint->GetTelemetryInfo()->AllWriteMetrics();
143+
server_telemetry_info ? server_telemetry_info->AllWriteMetrics()
144+
: std::vector<size_t>{};
141145
server_write_args.set_metrics_sink(WriteEventSink(
142146
server_write_metrics,
143147
{WriteEvent::kSendMsg, WriteEvent::kScheduled, WriteEvent::kSent,

0 commit comments

Comments
 (0)